-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error boundaries WD-8089 #595
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo starting at https://lxd-ui-595.demos.haus |
edlerd
force-pushed
the
add-error-boundaries
branch
2 times, most recently
from
January 5, 2024 11:00
ad397c3
to
cd5606b
Compare
QA looks good (locally forcing an error)! Perhaps we can pass the actual error component as a |
Signed-off-by: David Edler <david.edler@canonical.com>
edlerd
force-pushed
the
add-error-boundaries
branch
from
January 5, 2024 13:07
cd5606b
to
69ee84a
Compare
Split out the |
mas-who
approved these changes
Jan 5, 2024
LGTM. We should wait for @piperdeck to give some design input |
piperdeck
added
Review: User testing +1
Review: Design +1
and removed
Review: Design needed
Review: User testing +1
labels
Jan 5, 2024
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Fixes: WD-8089
QA
throw new Error("foo");
toInstanceList.tsx
Screenshot
Error in a content component:
Error in navigation or a component higher in the component tree: