Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage #634

Merged
merged 1 commit into from
Feb 21, 2024
Merged

Add test coverage #634

merged 1 commit into from
Feb 21, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Feb 5, 2024

Done

  • adding coverage for test runs

Fixes WD-8680

QA

  1. Perform the following QA steps:

@edlerd edlerd force-pushed the coverage branch 2 times, most recently from c42b1cc to 12942f7 Compare February 20, 2024 13:37
@edlerd edlerd changed the title chore(tests) add test coverage Add test coverage Feb 21, 2024
playwright.config.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
tests/fixtures/coverage.ts Show resolved Hide resolved
tests/fixtures/coverage.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
tests/instance-panel.spec.ts Show resolved Hide resolved
package.json Show resolved Hide resolved
.github/workflows/coverage.yaml Show resolved Hide resolved
@mas-who
Copy link
Collaborator

mas-who commented Feb 21, 2024

QA on this forked action, will check once done.

@mas-who
Copy link
Collaborator

mas-who commented Feb 21, 2024

QA looks good https://mas-who.github.io/lxd-ui/coverage/, numbers match between the text output in action run and the final report upload.

Signed-off-by: David Edler <david.edler@canonical.com>
@edlerd edlerd merged commit 0427e00 into canonical:main Feb 21, 2024
10 checks passed
@edlerd edlerd deleted the coverage branch February 21, 2024 16:24
github-actions bot pushed a commit that referenced this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants