Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: lxd permissions management [WD-9458] #694

Merged
merged 1 commit into from
May 3, 2024
Merged

feature: lxd permissions management [WD-9458] #694

merged 1 commit into from
May 3, 2024

Conversation

mas-who
Copy link
Collaborator

@mas-who mas-who commented Mar 12, 2024 •
edited
Loading

Done

  • identities management
    • Identities list screen
    • Disable selection for tls identities on identities list
    • Identities detail overview
    • Identities detail groups view
    • TLS identities does not have groups view
    • Identities modify groups for a single identity
    • Identities modify groups for multiple identities
    • History undo/redo control for modify groups panel with modified status shown
    • Nested side navigation for storage and permissions
    • Hide nav items when side navigation is collapsed
    • Hover to expand side navigation for medium screen widths
    • Edit identity groups confirm modal
    • Align header layout for storage pages
    • Adjusted navigation to enter "scroll mode" automatically depending on its content overflow
  • lxd groups management
    • lxd Groups list view
    • lxd Groups empty state view
    • setup for group actions menu
    • create lxd groups in side panel
    • edit lxd groups in sdie panel
    • manage identities
    • delete single group and bulk delete groups
    • modify group entitlements

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • TBC

@webteam-app
Copy link

Demo starting at https://lxd-ui-694.demos.haus

@mas-who mas-who force-pushed the lxd-permissions-management branch 21 times, most recently from 0d39dc4 to 886e030 Compare March 18, 2024 10:06
@mas-who mas-who force-pushed the lxd-permissions-management branch 5 times, most recently from 0151849 to 3c63d0e Compare March 19, 2024 13:18
@mas-who mas-who force-pushed the lxd-permissions-management branch 4 times, most recently from ee12a8c to 9f3fa3f Compare May 2, 2024 15:31
@mas-who mas-who force-pushed the lxd-permissions-management branch 4 times, most recently from 510cb0f to 5b7ad7c Compare May 2, 2024 19:29
edlerd
edlerd reviewed May 2, 2024
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty neat and very close to perfect. Only 7% left :)

grafik

src/components/NavAccordion.tsx Outdated Show resolved Hide resolved
src/components/Navigation.tsx Outdated Show resolved Hide resolved
src/sass/_pattern_navigation.scss Show resolved Hide resolved
src/sass/_side_panel.scss Outdated Show resolved Hide resolved
src/sass/_permission_group_selection.scss Show resolved Hide resolved
src/sass/_permission_groups.scss Outdated Show resolved Hide resolved
@mas-who mas-who force-pushed the lxd-permissions-management branch from 5b7ad7c to cf47e58 Compare May 3, 2024 07:05
@mas-who mas-who force-pushed the lxd-permissions-management branch 2 times, most recently from 976813e to de7e292 Compare May 3, 2024 10:00
edlerd
edlerd reviewed May 3, 2024
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

99% done, found one critical bug with the navigation on small screens.

src/components/Navigation.tsx Show resolved Hide resolved
src/components/Navigation.tsx Show resolved Hide resolved
src/components/ScrollableContainer.tsx Outdated Show resolved Hide resolved
@mas-who mas-who force-pushed the lxd-permissions-management branch from de7e292 to 9b85684 Compare May 3, 2024 13:39
edlerd
edlerd reviewed May 3, 2024
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more refinements on the new navigation.

src/components/Navigation.tsx Show resolved Hide resolved
src/components/ScrollableContainer.tsx Outdated Show resolved Hide resolved
@mas-who mas-who force-pushed the lxd-permissions-management branch 2 times, most recently from 6f2a181 to 85de678 Compare May 3, 2024 14:50
@piperdeck

This comment was marked as resolved.

Sign in to view
@piperdeck

This comment was marked as resolved.

Sign in to view
@mas-who
feature: lxd permissions management
5d0500e 
done:
- identities management
    - Identities list screen
    - Disable selection for tls identities on identities list
    - Identities detail overview
    - Identities detail groups view
    - TLS identities does not have groups view
    - Identities modify groups for a single identity
    - Identities modify groups for multiple identities
    - History undo/redo control for modify groups panel with modified status shown
    - Nested side navigation for storage and permissions
    - Hide nav items when side navigation is collapsed
    - Hover to expand side navigation for medium screen widths
    - Edit identity groups confirm modal
    - Align header layout for storage pages
    - Adjusted navigation to enter "scroll mode" automatically depending on its content overflow
- lxd groups management
    - lxd Groups list view
    - lxd Groups empty state view
    - Setup for group actions menu
    - Create lxd groups in side panel

Signed-off-by: Mason Hu <mason.hu@canonical.com>
@mas-who mas-who force-pushed the lxd-permissions-management branch from 85de678 to 5d0500e Compare May 3, 2024 14:55
edlerd
edlerd approved these changes May 3, 2024
View reviewed changes
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now, thanks for the long ride and making it perfect :)

@mas-who
Copy link
Collaborator Author

mas-who commented May 3, 2024

All good now, thanks for the long ride and making it perfect :)

Thanks @edlerd for the dedicated reviews! 💯

@mas-who mas-who merged commit 1c39400 into canonical:main May 3, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request May 3, 2024
workflow: remove all reports for PR #694
d44846e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ru-fu ru-fu ru-fu left review comments

@edlerd edlerd edlerd approved these changes

@huwshimi huwshimi Awaiting requested review from huwshimi

@vladimir-cucu vladimir-cucu Awaiting requested review from vladimir-cucu

Assignees

@piperdeck piperdeck

Labels
Review: Code needed Review: Design +1 Review: QA needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mas-who @webteam-app @piperdeck @edlerd @ru-fu