New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for custom fields on all entities #712

Merged

edlerd merged 1 commit into canonical:main from edlerd:tests-for-custom-fields

Mar 27, 2024

Collaborator

edlerd commented Mar 25, 2024 •

edited

Loading

Done

add tests for custom fields on instances, profiles, projects, networks, storage pools and storage volumes

Fixes WD-9656

QA

Run the LXD-UI:
- On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
- With a local copy of this branch, run as described here.
Perform the following QA steps:
- ensure test suite passes and includes the new tests

webteam-app commented Mar 25, 2024

Demo starting at https://lxd-ui-712.demos.haus

edlerd added the Review: Code needed label

mas-who reviewed

View reviewed changes

src/pages/profiles/EditProfile.tsx Show resolved Hide resolved

mas-who reviewed

View reviewed changes

src/util/instanceEdit.spec.ts Outdated Show resolved Hide resolved

mas-who reviewed

View reviewed changes

src/util/instanceEdit.spec.ts Outdated Show resolved Hide resolved

mas-who reviewed

View reviewed changes

src/util/networkForm.spec.ts Outdated Show resolved Hide resolved

mas-who reviewed

View reviewed changes

vitest.config.ts

@@ @@ -8,6 +8,7 @@ export default mergeConfig( @@
                     sourcemap: "inline",
                   },
                   test: {
+                    environment: "jsdom",

Collaborator

mas-who Mar 26, 2024

what does this do?

Collaborator Author

edlerd Mar 27, 2024

I did face crashes on testing functions with custom CSS styles from react-components in the default environment node. The change to jsdom is emulating a more realistic browser environment. This resolved this issue. See also vite test docs on this.

Collaborator

mas-who commented Mar 26, 2024

just some minor wording changes, although it's opinionated so feel free to disregard it if you feel like otherwise 🙂

mas-who added Review: Code +1 and removed Review: Code needed labels

mas-who approved these changes

View reviewed changes


          feat(test) add tests for custom fields on instances, profiles, projec…

a768b51

…ts, networks, storage pools and storage volumes WD-9656

Signed-off-by: David Edler <david.edler@canonical.com>

edlerd force-pushed the tests-for-custom-fields branch from d3a6d36 to a768b51 Compare

March 27, 2024 09:11

edlerd merged commit 47c1f06 into canonical:main

9 checks passed

edlerd deleted the tests-for-custom-fields branch

March 27, 2024 09:13

github-actions bot pushed a commit that referenced this pull request


          workflow: remove all reports for PR #712

020240a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review: Code +1