Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fetch all volumes endpoint #718

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Mar 28, 2024

Done

  • use fetch all volumes endpoint
  • we used to fetch all storage pools and then all volumes for each pool, with List all storage volumes via API lxd#12550 a new endpoint to directly fetch all storage volumes is available, this PR is starting to use it.
  • This only works with the latest/edge version of lxd

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • ensure storages -> volumes page is working as before

@webteam-app
Copy link

@edlerd edlerd requested a review from mas-who April 3, 2024 12:27
@mas-who
Copy link
Collaborator

mas-who commented Apr 4, 2024

Interesting observation:

old way of getting volumes:
Screenshot from 2024-04-04 11-16-35

new way of getting volumes:
Screenshot from 2024-04-04 11-18-02

The new way of fetching volumes actually resulted in longer response time from server, this is due to the old way of fetching volumes sends concurrent requests to the server. I think it's still better since we are not overloading the server.

@mas-who
Copy link
Collaborator

mas-who commented Apr 4, 2024

QA looks good, just one small change for code 🙂

Signed-off-by: David Edler <david.edler@canonical.com>
@mas-who
Copy link
Collaborator

mas-who commented Apr 4, 2024

LGTM 👍 thanks for the update

@edlerd edlerd merged commit 67ea93b into canonical:main Apr 4, 2024
10 checks passed
@edlerd edlerd deleted the use-all-volumes-endpoint branch April 4, 2024 11:18
github-actions bot pushed a commit that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants