Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create instance from custom image #721

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Apr 3, 2024

Done

  • fix instance creation from custom images: needs fingerprint in payload.source

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @mas-who or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:

…payload.source

Signed-off-by: David Edler <david.edler@canonical.com>
@webteam-app
Copy link

@edlerd
Copy link
Collaborator Author

edlerd commented Apr 3, 2024

This should fix the underlying issue. Created a ticket to cover this with an e2e test in the future.

@mas-who
Copy link
Collaborator

mas-who commented Apr 4, 2024

LGTM 👍

@edlerd edlerd merged commit a067da1 into canonical:main Apr 4, 2024
10 checks passed
@edlerd edlerd deleted the fix-custom-image-creation branch April 4, 2024 11:18
github-actions bot pushed a commit that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants