Add custom image test WD-10108 #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
edlerd
force-pushed
the
add-image-test
branch
2 times, most recently
from
8f5b2f6
to
ea27976
Compare
Signed-off-by: David Edler <david.edler@canonical.com>
edlerd
force-pushed
the
add-image-test
branch
3 times, most recently
from
606ce43
to
1c92de7
Compare
Signed-off-by: David Edler <david.edler@canonical.com>
mas-who
reviewed
Apr 10, 2024
mas-who
reviewed
Apr 10, 2024
| import { test } from "./fixtures/lxd-test"; | ||
| import { deleteInstance, randomInstanceName } from "./helpers/instances"; | ||
|
|
||
| test("search for custom image and create an instance from it", async ({ |
There was a problem hiding this comment.
this test would fail locally I think, maybe we should skip it for dev environment? Or we could setup a shell script to run before the e2e tests kicks off?
There was a problem hiding this comment.
Right, this hinges on the availability of the custom image.
I was planning to extend this test to create the custom image from the UI in the next cycle (as we have the item to add support for that on our roadmap). Maybe we can ignore this incompatibility for local test runs for now and manually create the custom image on our dev machines?
|
I see the test run time came down a fair bit, nice! Just one query about running the custom image test locally |
mas-who
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Fixes WD-10108
QA