Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run PR tests on 5.0/edge, 5.21/edge and latest/edge #750

Merged
merged 6 commits into from
Apr 22, 2024

Conversation

simondeziel
Copy link
Member

For CI jobs, it's best to catch issues soon after their introduction (edge) before they reach users (stable).

@webteam-app
Copy link

simondeziel is not a collaborator of the repo

@simondeziel simondeziel marked this pull request as draft April 19, 2024 17:34
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
For CI jobs, it's best to catch issues soon after their introduction (`edge`)
before they reach users (`stable`).

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel simondeziel marked this pull request as ready for review April 19, 2024 18:33
@simondeziel
Copy link
Member Author

Marking as ready for review despite the failing 5.0/edge tests due to timeouts. I cannot retry those :/

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
ARCHITECTURE.MD Outdated Show resolved Hide resolved
Copy link
Collaborator

@edlerd edlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment above from mason to fix documentation.

Thanks for submitting the PR :)

Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
@simondeziel
Copy link
Member Author

@edlerd I've addressed the last comment and force pushed. Thanks!

@edlerd edlerd merged commit adba742 into canonical:main Apr 22, 2024
12 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 22, 2024
@simondeziel simondeziel deleted the more-lxd-versions branch April 22, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants