-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run PR tests on 5.0/edge
, 5.21/edge
and latest/edge
#750
Conversation
simondeziel is not a collaborator of the repo |
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
For CI jobs, it's best to catch issues soon after their introduction (`edge`) before they reach users (`stable`). Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
f92a1db
to
9e00384
Compare
Marking as ready for review despite the failing |
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
9e00384
to
ed6ff42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one comment above from mason to fix documentation.
Thanks for submitting the PR :)
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
Signed-off-by: Simon Deziel <simon.deziel@canonical.com>
ed6ff42
to
f77b9b4
Compare
@edlerd I've addressed the last comment and force pushed. Thanks! |
For CI jobs, it's best to catch issues soon after their introduction (
edge
) before they reach users (stable
).