Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note and workaround for nip.io in tests #2479

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

johnlettman
Copy link
Contributor

This PR adds a note to the build documentation about the use of nip.io in tests. Networks implementing DNS rebinding protection may block the resolution of loopback addresses as documented on the nip.io page.

On my own network, this condition lead to failed tests.

The note includes a /etc/hosts workaround.

Checklist

Also verify you have:

@balchua
Copy link
Collaborator

balchua commented Jul 28, 2021

IMHO, this will be better have it documented in https://discuss.kubernetes.io/t/add-on-dashboard/11289, which can translate to the official MicroK8s documentation.

@johnlettman
Copy link
Contributor Author

Hello @balchua !

I agree the thread you linked is the best place to outline the consideration of the nip.io domain and the changes of PR #2478.

In addition to the changes of that PR, the microk8s tests also use the nip.io domain (ingress mainly) and can fail as a result of the network using DNS rebinding protection. This PR targets the build documentation where testing information is located to warn the developer of this potential.

Copy link
Member

@ktsakalozos ktsakalozos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR @jlettman just a minor change requests.

@johnlettman
Copy link
Contributor Author

@ktsakalozos Might be nitpicking, but should the note be before the test procedure as a warning?
I wish GH flavored markdown incorporated the admonition feature akin to ASCIIDoc ;) maybe someday.

@neoaggelos neoaggelos self-requested a review November 17, 2021 09:33
@neoaggelos neoaggelos merged commit b724320 into canonical:master Nov 17, 2021
@neoaggelos
Copy link
Contributor

Thanks @jlettman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants