-
Notifications
You must be signed in to change notification settings - Fork 767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note and workaround for nip.io in tests #2479
Conversation
IMHO, this will be better have it documented in https://discuss.kubernetes.io/t/add-on-dashboard/11289, which can translate to the official MicroK8s documentation. |
Hello @balchua ! I agree the thread you linked is the best place to outline the consideration of the In addition to the changes of that PR, the microk8s tests also use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR @jlettman just a minor change requests.
@ktsakalozos Might be nitpicking, but should the note be before the test procedure as a warning? |
Thanks @jlettman |
This PR adds a note to the build documentation about the use of nip.io in tests. Networks implementing DNS rebinding protection may block the resolution of loopback addresses as documented on the nip.io page.
On my own network, this condition lead to failed tests.
The note includes a
/etc/hosts
workaround.Checklist
Also verify you have: