Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[actions] Continue on Coverage build errors #3473

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Conversation

townsend2010
Copy link
Contributor

This will help allow builds to continue while the issue of tokenless uploads to Codecov is worked out.

See codecov/codecov-action#1359 for more details.

This will help allow builds to continue while the issue of tokenless
uploads to Codecov is worked out.
@townsend2010 townsend2010 force-pushed the ignore-coverage-failure branch 4 times, most recently from 50e6b6b to 0e0a651 Compare April 8, 2024 21:04
Copy link

github-actions bot commented Apr 8, 2024

Some tests with 'continue-on-error: true' have failed:

  • Error with measuring coverage in Coverage build

  • Error with measuring coverage in Coverage build

    Created by continue-on-error-comment

@townsend2010 townsend2010 marked this pull request as ready for review April 8, 2024 22:31
Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As clarified elsewhere, the fact that the run shows green with continue-on-error is a GH issue, and this is only a temporary workaround to unblock us until Codecov fixes things, so +1.

@ricab ricab added this pull request to the merge queue Apr 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 9, 2024
@ricab ricab merged commit ae0f998 into main Apr 9, 2024
18 of 20 checks passed
@ricab ricab deleted the ignore-coverage-failure branch April 9, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants