Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: limit tenacity to 8.3 or earlier #443

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

tonyandrewmeyer
Copy link

@tonyandrewmeyer tonyandrewmeyer commented Jun 25, 2024

Issue

Tests do not pass with tenacity 8.4

Solution

Pin to < 8.4 (I assume you'll want to figure out what needs to be done to support 8.4, but for now this gets things to pass if re-locking).

Workaround for #442.

@dimaqq
Copy link

dimaqq commented Jun 25, 2024

Judging by the changes, the content is:

  • limit tenacity dep to <8.4
  • and re-lock

The repo maintainer may or may not want the re-lock because that bumps up a whole bunch of packages, though typically only micro bumps.

P.S. given that old version restriction was ^8.2.2, maybe a more precise version spec can be done, like >=8.2.2,<8.4 ?

The @paulomach should decide 🙇🏻

@carlcsaposs-canonical
Copy link
Contributor

The repo maintainer may or may not want the re-lock because that bumps up a whole bunch of packages

yes, please re-lock by checking out poetry.lock from main and running tox run -e format or poetry lock --no-update

we'll update other dependencies in our renovate PRs

@carlcsaposs-canonical
Copy link
Contributor

reverted updates of unrelated packages & added back version floor to range in 5e8bec4

@carlcsaposs-canonical
Copy link
Contributor

updated PR description to remove "fixes" on issue so that original issue stays open (so we fix our unit tests & remove the upper pin)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants