Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sync_docs.yaml #332

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Update sync_docs.yaml #332

merged 2 commits into from
Aug 20, 2024

Conversation

a-velasco
Copy link
Contributor

A new sync_docs.yaml workflow was released in data-platform-workflows v19.2.0. It overwrites the old experimental _sync_docs.yaml workflow and releases it to the public interface.

This PR:

  • Corrects the filename to match the new syntax without the experimental _ prefix.
  • Removes the now unnecessary Discourse API credentials
  • Adds automatic reviewers

Copy link

codecov bot commented Aug 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.09%. Comparing base (0fed08b) to head (1dbf462).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   73.09%   73.09%           
=======================================
  Files           8        8           
  Lines        1286     1286           
  Branches      224      224           
=======================================
  Hits          940      940           
  Misses        267      267           
  Partials       79       79           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@carlcsaposs-canonical carlcsaposs-canonical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is schedule up-to-date?

@dragomirp dragomirp merged commit f9800d2 into main Aug 20, 2024
55 checks passed
@dragomirp dragomirp deleted the update-sync-docs branch August 20, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants