Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Suppress oversee user action #509

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

dragomirp
Copy link
Contributor

No description provided.

@taurus-forever
Copy link
Contributor

@dragomirp abandon due to #507 ?

@dragomirp
Copy link
Contributor Author

@dragomirp abandon due to #507 ?

It's a continuation if we decide to add the action at some point. I will rebase once #507 gets merged.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.81%. Comparing base (713f6e4) to head (6dded68).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
+ Coverage   69.72%   69.81%   +0.09%     
==========================================
  Files          11       11              
  Lines        2870     2879       +9     
  Branches      508      510       +2     
==========================================
+ Hits         2001     2010       +9     
  Misses        763      763              
  Partials      106      106              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +65 to +66
reenable-oversee-users:
description: Reenable purging of managed credentials after a standby cluster is promoted.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why it is not run as part of promote-to-primary action?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original issue was the promoting the replica cluster deleted users for relations to the old primary cluster, since there were no relations for them in the new primary cluster. We can't know if the client charms got rerelated to the new primary cluster, so we can't know when it's safe to reenable that functionality without user input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants