Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Enzyme. #853

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Remove Enzyme. #853

merged 2 commits into from
Nov 15, 2022

Conversation

huwshimi
Copy link
Collaborator

Note: This should land once all the other RTL PRs have been merged.

Done

  • Remove Enzyme so that React can be upgraded to v18.

QA

n/a

Fixes

Fixes: #750.

@webteam-app
Copy link

Demo starting at https://react-components-853.demos.haus

@huwshimi
Copy link
Collaborator Author

This is ready for review now.

bartaz
bartaz approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for all this effort @huwshimi !

@bartaz bartaz merged commit 2546ab7 into canonical:main Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartaz bartaz bartaz approved these changes

Assignees
No one assigned
Labels
Maintenance 🔨 Review: Code +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate enzyme tests to @testing-library/react
3 participants
@huwshimi @webteam-app @bartaz