cmd/snap: make 1.18 vet happy #11532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go vet in 1.18 is more picky about fmt.*rintln and additional newlines at the end of output, thus producing errors like: ./cmd_info_test.go:1197:4: fmt.Fprintln arg list ends with redundant newline ./cmd_info_test.go:1201:4: fmt.Fprintln arg list ends with redundant newline ./cmd_routine_portal_info_test.go:101:4: fmt.Fprintln arg list ends with redundant newline ./cmd_routine_portal_info_test.go:161:4: fmt.Fprintln arg list ends with redundant newline ./cmd_run_test.go:1755:5: fmt.Fprintln arg list ends with redundant newline See golang/go#49350 and https://go.dev/doc/go1.18#vet Although I believe we should not be hitting this case, still it does not make sense to output so many newlines, so it's worth fixing. Signed-off-by: Maciej Borzecki <maciej.zenon.borzecki@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go vet in 1.18 is more picky about fmt.*rintln and additional newlines at the
end of output, thus producing errors like:
See golang/go#49350 and https://go.dev/doc/go1.18#vet
Although I believe we should not be hitting this case, still it does not make
sense to output so many newlines, so it's worth fixing.