Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gadget: emmc syntax support #14533

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Meulengracht
Copy link
Member

@Meulengracht Meulengracht commented Sep 24, 2024

This is the first PR of 3 (likely) in the road to emmc support.

The first PR (this one)

  • Implement the neccessary syntax support for gadgets to specifiy eMMC hardware boot partitions and which images go there during gadget updates

Next PRs:

REF: SNAPDENG-32142

@Meulengracht Meulengracht marked this pull request as ready for review October 4, 2024 07:50
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 96.47059% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.87%. Comparing base (ac897ee) to head (bed97d5).
Report is 52 commits behind head on master.

Files with missing lines Patch % Lines
gadget/gadget.go 95.77% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14533      +/-   ##
==========================================
+ Coverage   78.85%   78.87%   +0.02%     
==========================================
  Files        1079     1083       +4     
  Lines      145615   146157     +542     
==========================================
+ Hits       114828   115285     +457     
- Misses      23601    23675      +74     
- Partials     7186     7197      +11     
Flag Coverage Δ
unittests 78.87% <96.47%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant