Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: enable macos tests on fde-manager-features #14557

Conversation

valentindavid
Copy link
Contributor

No description provided.

@valentindavid valentindavid force-pushed the valentindavid/fde-manager-features-enable-macos-tests branch from 08218aa to 5dfbd8b Compare September 30, 2024 14:12
@valentindavid valentindavid force-pushed the valentindavid/fde-manager-features-enable-macos-tests branch from 5dfbd8b to 341c31c Compare September 30, 2024 14:17
@valentindavid valentindavid added the FDE Manager Pull requests that target FDE manager branch label Sep 30, 2024
@valentindavid valentindavid marked this pull request as ready for review September 30, 2024 14:22
@@ -2,7 +2,7 @@ name: MacOS quick checks
on:
# Only run on pull requests: not pushes
pull_request:
branches: ["master", "release/**"]
branches: ["master", "release/**", "fde-manager-features"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe add a TODO with a note to drop it at some point?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plan is to not merge this commit to master.

Copy link
Member

@alfonsosanchezbeato alfonsosanchezbeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@pedronis pedronis merged commit 5cc7d7a into canonical:fde-manager-features Sep 30, 2024
43 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FDE Manager Pull requests that target FDE manager branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants