o/snapstate: bump timeout in test*ComponentsRunThrough variants #14564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14564 +/- ##
==========================================
+ Coverage 78.85% 78.88% +0.02%
==========================================
Files 1079 1082 +3
Lines 145615 146058 +443
==========================================
+ Hits 114828 115218 +390
- Misses 23601 23645 +44
- Partials 7186 7195 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I spent a while trying to reproduce this issue by running the spread test manually, but I wasn't able to catch it in the act. I'm pretty confident the failures we're seeing are because of a timeout that is too low, since the state of the tasks when settle times out has been different in the cases where we have seen a failure. This indicates to me that we're not getting stuck on something specific.
Regardless, if we have a real issue where something is getting completely blocked, this won't solve anything. However, if the issue is that our timeout is just too low, then hopefully this will make things better.