Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vanilla to 3.12.1 #12664

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

jpmartinspt
Copy link
Contributor

Done

Bump vanilla to 3.12.1

QA

  • Check out this feature branch
  • Run the site using the command ./run serve or dotrun
  • Check in the following pages that the small caps text looks good:
    • /pro
    • /pro/dashboard
    • /pro/tutorial
    • /pricing/pro
    • /certified/why-certify
    • /security/esm

@webteam-app
Copy link

Demo starting at https://ubuntu-com-12664.demos.haus

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #12664 (a2307ce) into main (93d2b00) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #12664   +/-   ##
=======================================
  Coverage   73.66%   73.66%           
=======================================
  Files         104      104           
  Lines        2681     2681           
  Branches      835      835           
=======================================
  Hits         1975     1975           
  Misses        678      678           
  Partials       28       28           
Impacted Files Coverage Δ
...js/src/advantage/offers/components/Offer/Offer.tsx 100.00% <ø> (ø)
...bscriptions/SubscriptionList/ListCard/ListCard.tsx 95.00% <ø> (ø)
...criptions/SubscriptionList/ListGroup/ListGroup.tsx 100.00% <ø> (ø)
...js/src/advantage/users/components/Organisation.tsx 100.00% <ø> (ø)

@anthonydillon
Copy link
Contributor

anthonydillon commented Mar 10, 2023

There are some over effected muted-headings:
image

Which looks like it matches Vanilla: https://vanillaframework.io/docs/patterns/muted-heading

@anthonydillon
Copy link
Contributor

LGTM, filed a separate issue for the list change canonical/vanilla-framework#4696

Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and QA (but not every page but a lot) 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants