-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP fix: Allow pop up notifications to go under the navigation when scrolling #14222
base: main
Are you sure you want to change the base?
Conversation
Thank you, this definitely works but the scroll brings the navigation now over the notification. Could you try adding |
@petesfrench Would you mind updating the description of this to explain exactly what all these changes are? This seems like a large number of modifications for something that reads as simply needing a z-index tweak, and I'm not sure why all these changes were made. |
@pastelcyborg Sure thing. Note that the majority of the changes come from formatting changes applied by Jinja. The scope of the pr has not changed. I got a little stuck on this and haven't had time to jump back into it. If you want to look into it and see if you can get it working feel free |
After looking into this a bit further, I think my inclination here would actually be to make the @petesfrench Thoughts? |
Done
QA
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-11728