Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples toolbar hides bottom content of tall examples #5283

Closed
jmuzina opened this issue Aug 7, 2024 · 2 comments · Fixed by #5309
Closed

Examples toolbar hides bottom content of tall examples #5283

jmuzina opened this issue Aug 7, 2024 · 2 comments · Fixed by #5309
Assignees

Comments

@jmuzina
Copy link
Member

jmuzina commented Aug 7, 2024

When viewing an example that is taller than the viewport (i.e. forms combined), the examples toolbar hides some content behind it.

Screenshot 2024-08-07 at 1 05 42 PM

This isn't a problem in Percy, as the toolbar is hidden for Percy tests. However it makes it hard to see what's behind the toolbar on a browser.

We should either adjust the page height to make room for the toolbar, or display the settings some other way (like a modal / aside).

Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/WD-13996.

This message was autogenerated

@bartaz
Copy link
Member

bartaz commented Aug 8, 2024

I noticed this as well when working with navigation.

In most cases (long content) adding some margin bottom on body would be sufficient, so you can scroll past this.
But in case of navigation on mobile, its position is fixed, so it won't help.

Moving the toolbar to some other place also only partially solves the problem (it will still cover some part of the screen).

I guess we need some way to hide/toggle this toolbar.
A simpler approach would be to just allow closing it, and reload to make it reappear.
Because if we want to be able to really toggle it, there would still be a need for some "collapsed" view that can be expanded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants