Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to close example toolbar #5309

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Aug 16, 2024

Done

Adds a button to the example controls toolbar that closes the controls toolbar. This allows content behind the toolbar to be seen.

Fixes #5283 , WD-13996

QA

  • Open any example. Try button.
  • Click the "Close" button in the example toolbar.
  • Verify the example controls toolbar is removed from view.
  • Refresh the page.
  • Verify the toolbar is rendered again.

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

Screenshot 2024-08-19 at 1 16 47 PM

@webteam-app
Copy link

@jmuzina jmuzina marked this pull request as ready for review August 16, 2024 21:54
@jmuzina
Copy link
Member Author

jmuzina commented Aug 16, 2024

I think I'll make a change on Monday to make the elements in the toolbar have less gap between them on small, so that the toolbar isn't as tall on mobile

@jmuzina jmuzina marked this pull request as draft August 19, 2024 13:23
@jmuzina jmuzina marked this pull request as ready for review August 19, 2024 17:17
@jmuzina jmuzina marked this pull request as draft August 20, 2024 18:21
@jmuzina jmuzina marked this pull request as ready for review August 20, 2024 18:23
@jmuzina jmuzina added Review: Percy needed This PR needs a review of Percy for visual regressions and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Aug 20, 2024
@jmuzina jmuzina merged commit 416588d into canonical:main Aug 20, 2024
8 checks passed
@jmuzina jmuzina deleted the hide-example-toolbar branch August 20, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Examples toolbar hides bottom content of tall examples
3 participants