Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close side nav drawer when anchors are clicked #4489

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Jun 9, 2022

Done

Closes side navigation when in-page anchors are clicked

Fixes #4484

QA

  • Open demo
  • Visit any Vanilla docs page on small screen
  • Open the side navigation
  • Click on any anchor link to a heading on the current page
  • Side nav should close and page should be scrolled to correct position

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4489.demos.haus

@bartaz bartaz marked this pull request as ready for review June 9, 2022 07:48
@anthonydillon anthonydillon self-assigned this Jun 9, 2022
Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and QA +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs navigation is not working on small screens
3 participants