-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated middot list style #4499
Conversation
Demo starting at https://vanilla-framework-4499.demos.haus |
scss/_patterns_lists.scss
Outdated
position: absolute; | ||
right: -$sp-unit; | ||
position: relative; | ||
right: -(math.div($sp-unit, 2)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This solution works great, thanks!
Where does the $sp-unit
/ 2 value come from? Does it need to be exactly that, or just an arbitrary value to keep the dot centered? If it's not necesarily related to sp-unit maybe it should be hardcoded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it just centers the dot horizontally. It can be hardcoded. I did it like that because $sp-unit
is used there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks!
Done
Fixes #4429
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots