Add desktop icon #4624
Merged
Add desktop icon #4624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edlerd
added
Feature 🎁
|
Demo starting at https://vanilla-framework-4624.demos.haus |
edlerd
force-pushed
the
add-desktop-icon
branch
2 times, most recently
from
c46f334
to
f80fbb1
Compare
|
This seems to look different than the one from JIRA:
|
|
I had the wrong icon committed first, now it is the right one (also visible in the demo-docs): I just saw the dark icon is wired at https://vanilla-framework-4624.demos.haus/docs/examples/patterns/icons/icons-additional I'll fix it as well. |
edlerd
force-pushed
the
add-desktop-icon
branch
from
f80fbb1
to
58e5c4d
Compare
|
Now it is the right icon in light and dark theme. |
|
+1 |
bartaz
force-pushed
the
add-desktop-icon
branch
from
58e5c4d
to
9735b8f
Compare
|
Thanks @edlerd and sorry it took a while to get it reviewed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new desktop icon as requested via https://warthogs.atlassian.net/browse/DES-97