Removed highlight of side nav items on search results page [WD-2276]

[lorumic]

Done

Removed highlight of side nav items on the search results page.

Fixes #4486

QA

• Open an example search page.
• Check that no item is selected in side nav.

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

• PR should have one of the following labels to automatically categorise it in release notes:
  • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
• Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
  • if CSS class names are not changed it can be bugfix relesase (x.x.X)
  • if CSS class names are changed/added/removed it should be minor version (x.X.0)
  • see the wiki for more details
• Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
• Documentation side navigation should be updated with the relevant labels.

[webteam-app]

Demo starting at https://vanilla-framework-4682.demos.haus

[bartaz]

Why not add the exception here, where we already have a "/docs exception

Not sure if that would work but something like:

docs_slug = "" if docs_slug == "/docs" or docs_slug == "/docs/search" else docs_slug

[lorumic]

That was the first thing that I tried, but actually the /docs/ part of the path gets already replaced one instruction before:

        docs_slug = (
            flask.request.path.replace("/docs/", "")
            .replace("/design/", "")
            .replace("/accessibility", "")
        )

so this condition: docs_slug == "/docs/search" will never be matched.

[bartaz]

Ah, right!

[bartaz]

LGTM, thanks!