Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes incorrect aria-label on tabs examples #4701

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Fixes incorrect aria-label on tabs examples #4701

merged 1 commit into from
Mar 15, 2023

Conversation

petesfrench
Copy link
Contributor

Done

Fixes incorrect aria-label on tabs examples

QA

  • Go to /docs/patterns/tabs
  • See that the aria-label for the charmhub panel is "charmhub" and not "complex"

@petesfrench petesfrench added Review: QA needed Documentation 📝 Documentation changes or updates labels Mar 14, 2023
@webteam-app
Copy link

Demo starting at https://vanilla-framework-4701.demos.haus

bartaz
bartaz approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks for sorting that out. Seems like we copied this mistake into many places.

@bartaz bartaz merged commit 5480eab into main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bartaz bartaz bartaz approved these changes

Assignees
No one assigned
Labels
Documentation 📝 Documentation changes or updates Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petesfrench @webteam-app @bartaz