-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grid offsets #4741
Fix grid offsets #4741
Conversation
Demo starting at https://vanilla-framework-4741.demos.haus |
@ClementChaumel small thing - we have this I guess we need to extend the |
Ah yes nice catch! |
It should be fixed, PTAL @bartaz |
Co-authored-by: Bartek Szopka <83575+bartaz@users.noreply.github.com>
Co-authored-by: Bartek Szopka <83575+bartaz@users.noreply.github.com>
Co-authored-by: Bartek Szopka <83575+bartaz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some SCSS warnings to fix
&:nth-child(2) { | ||
@include vf-grid-column(calc($grid-columns / 4 * 3)); | ||
// if there is only one column we offset it to the right | ||
&:only-of-type { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noticed that, this is pretty cool!
I'm not super sure it's clear that it does that, but before we have any better implementation of the offset we can keep that. I like the simplicity of it, even if not super explicitly clear that this is gonna work this way. Especially that no other variants of this row do this. But maybe they can?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Done
Restored the prefix to the original value
explicitely set the target to
.col
in the common grid patterns