Update rule-highlight pattern to use to appropriate class #4759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://vanilla-framework-4759.demos.haus |
petesfrench
added
Review: QA needed
Review: Code needed
Bug 🐛
Documentation 📝
|
Thanks @petesfrench, but I think there is something else wrong with this original example, it wasn't supposed to look like that. I'll have a look to verify. |
|
The example with nested grid and rules was broken, I guess this must have happened because of some merge/rebase. Should be properly fixed now. |
|
Thanks @bartaz! |
bartaz
added a commit
that referenced
this pull request
May 17, 2023
* Update rule-highlight pattern to use to appropriate class * Fix missing highlight rule in the example --------- Co-authored-by: Bartek Szopka <bartek.szopka@canonical.com>
bartaz
added a commit
that referenced
this pull request
May 26, 2023
* Update rule-highlight pattern to use to appropriate class * Fix missing highlight rule in the example --------- Co-authored-by: Bartek Szopka <bartek.szopka@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Update rule-highlight pattern to use to appropriate class
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.Screenshots
Before:
After: