-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ubuntu font 0.869 and old style numerals #4812
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend the term text figures, possibly with a link to wikipedia. It is the most widely used way to refer to these, and it doesn't imply being old as in "out of date".
templates/docs/base/typography.md
Outdated
@@ -233,6 +233,14 @@ View example of the small caps text | |||
|
|||
Previously this style was implemented as `.p-text--x-small-capitalised` class name. This name is now deprecated and will be removed in next major version of Vanilla, please use `.p-text--small-caps` instead. | |||
|
|||
## Old-style numerals | |||
|
|||
Old-style numerals are a font feature that changes the appearance of numbers in text to match the height of lowercase letters. The small-caps text uses old-style numerals by default. To apply old-style numerals to other text, add the class `u-oldstyle-nums`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old-style numerals are a font feature that changes the appearance of numbers in text to match the height of lowercase letters. The small-caps text uses old-style numerals by default. To apply old-style numerals to other text, add the class `u-oldstyle-nums`. | |
Text figures are numerals designed to echo the varying height and alignment to the baseline of lowercase text. | |
### When to use: | |
Text figures work better when placed within small caps headings (with the class `.p-text--small-caps`), where we've set them as the new default. Generally, they are recommended within blocks of lowercase text too, although we haven't set that as a default. To apply old-style numerals styling, add the class `u-oldstyle-nums`. | |
### When not to use: | |
Text figures should never be used next to uppercase text. Care should be taken in tables and other scenarios where there is a lot of numeric data. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
b3a37c2
to
51a694f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2cbb9a3
to
ca5adac
Compare
Done
Fixes WD-4816
QA