Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu font 0.869 and old style numerals #4812

Merged
merged 7 commits into from
Jun 29, 2023

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Jun 28, 2023

Done

  • Updates to latest version of Ubuntu font
  • Uses old style numerals in small caps text
  • Adds utility to use old style numerals

Fixes WD-4816

QA

image

@bartaz bartaz changed the base branch from main to vanilla-4.0 June 28, 2023 14:25
@bartaz bartaz changed the title WIP: Ubuntu font 0.869 Ubuntu font 0.869 and old style numerals Jun 29, 2023
@bartaz bartaz marked this pull request as ready for review June 29, 2023 12:00
Copy link
Contributor

@lyubomir-popov lyubomir-popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend the term text figures, possibly with a link to wikipedia. It is the most widely used way to refer to these, and it doesn't imply being old as in "out of date".

@@ -233,6 +233,14 @@ View example of the small caps text

Previously this style was implemented as `.p-text--x-small-capitalised` class name. This name is now deprecated and will be removed in next major version of Vanilla, please use `.p-text--small-caps` instead.

## Old-style numerals

Old-style numerals are a font feature that changes the appearance of numbers in text to match the height of lowercase letters. The small-caps text uses old-style numerals by default. To apply old-style numerals to other text, add the class `u-oldstyle-nums`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Old-style numerals are a font feature that changes the appearance of numbers in text to match the height of lowercase letters. The small-caps text uses old-style numerals by default. To apply old-style numerals to other text, add the class `u-oldstyle-nums`.
Text figures are numerals designed to echo the varying height and alignment to the baseline of lowercase text.
### When to use:
Text figures work better when placed within small caps headings (with the class `.p-text--small-caps`), where we've set them as the new default. Generally, they are recommended within blocks of lowercase text too, although we haven't set that as a default. To apply old-style numerals styling, add the class `u-oldstyle-nums`.
### When not to use:
Text figures should never be used next to uppercase text. Care should be taken in tables and other scenarios where there is a lot of numeric data.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One ommission here, still says old style
image

Copy link
Contributor

@lyubomir-popov lyubomir-popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartaz bartaz merged commit fe6f17f into canonical:vanilla-4.0 Jun 29, 2023
4 checks passed
@renovate renovate bot mentioned this pull request Jul 31, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants