Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add display headings #4840

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Add display headings #4840

merged 3 commits into from
Jul 20, 2023

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Jul 19, 2023

Done

Adds display variant of heading component p-heading--display

Fixes WD-5124

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4840.demos.haus

@bartaz bartaz changed the title WIP: Add display headings Add display headings Jul 20, 2023
@bartaz bartaz marked this pull request as ready for review July 20, 2023 08:23
Copy link
Contributor

@lyubomir-popov lyubomir-popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bartaz added a few suggestions, hopefully I've not missed anything.

scss/_base_typography-definitions.scss Outdated Show resolved Hide resolved
scss/_settings_spacing.scss Show resolved Hide resolved
scss/_base_typography-definitions.scss Show resolved Hide resolved
Copy link
Contributor

@lyubomir-popov lyubomir-popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ClementChaumel ClementChaumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌️

@bartaz bartaz merged commit e4b9091 into canonical:main Jul 20, 2023
4 checks passed
@bartaz bartaz deleted the display-heading branch July 20, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants