-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update border and font in chips #4850
Update border and font in chips #4850
Conversation
eb68bbe
to
a47ef16
Compare
@bartaz Do you reckon it requires being mentioned in what's new? I feel like it's a small enough change to omit it |
No, purely visual changes that don't change the CSS class names are usually not mentined (unless they are really significant), so feel free to skip it here. |
Maybe? There seems to be line height difference, so if chip value uses small size, I guess lead part should as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From Percy it seems like chips got somehow 1px bigger or something, but I think it's OK.
Thanks!
Done
reduce width of the border
change font weight
use real small caps (instead of small uppercase)
Fixes WD-5198
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots