Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chevron top on mobile #4853

Merged
merged 3 commits into from
Aug 1, 2023
Merged

Fix chevron top on mobile #4853

merged 3 commits into from
Aug 1, 2023

Conversation

lemacarl
Copy link
Contributor

@lemacarl lemacarl commented Jul 31, 2023

Done

Set chevron top to 1rem on mobile and 1.25rem on desktop

Fixes #4758

QA

  • Open demo
  • Check chevron height in mobile and desktop mode using developer tools

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thank you for your contribution @lemacarl!

@bartaz bartaz merged commit cb9b14e into canonical:main Aug 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation chevron is too low on mobile view
3 participants