-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark theme for forms #4857
Dark theme for forms #4857
Conversation
Demo starting at https://vanilla-framework-4857.demos.haus |
Just 2 more things @bartaz 👍 |
@lyubomir-popov Updated the warning colour and coloured the symbols in icons using default dark background colour. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If design +1's it, merge it.
@bartaz One last thing, we have an accessibility falure - this text needs to use the Giving +1 with changes, so it can be merged quickly opnce this is addressed. |
Done
Adds dark theme to form inputs
Fixes WD-5201
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots