Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme for forms #4857

Merged
merged 14 commits into from
Aug 8, 2023
Merged

Dark theme for forms #4857

merged 14 commits into from
Aug 8, 2023

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Aug 2, 2023

Done

Adds dark theme to form inputs

Fixes WD-5201

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4857.demos.haus

@lyubomir-popov
Copy link
Contributor

lyubomir-popov commented Aug 2, 2023

Very close, a list of what I notice:

  • dropdowns need to be themed too:

image

  • I would use white for the validation text. The border tinting and icon is enough to satisfy accessibility requirements:

image

  • is the placeholder text grey? It should be white at the inactive text opacity:

image

@bartaz bartaz changed the title WIP: Dark forms Dark theme for forms Aug 4, 2023
@bartaz bartaz marked this pull request as ready for review August 4, 2023 11:07
@lyubomir-popov
Copy link
Contributor

image
this is still an issue for the first item

@lyubomir-popov
Copy link
Contributor

needs to be applied to focus and icons too, you might need svgs for the icons
image

@lyubomir-popov
Copy link
Contributor

Just 2 more things @bartaz 👍

  • we need to make the symbols inside the circles dark - #262626
  • the orange is not currently accessible compared to adjacent text - I used #C48831in figma, which is
    image

@bartaz
Copy link
Member Author

bartaz commented Aug 8, 2023

@lyubomir-popov Updated the warning colour and coloured the symbols in icons using default dark background colour.

Copy link
Contributor

@albertkol albertkol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If design +1's it, merge it.

@lyubomir-popov
Copy link
Contributor

lyubomir-popov commented Aug 8, 2023

@bartaz One last thing, we have an accessibility falure - this text needs to use the $colors--dark-theme--text-muted variable to be readable:

image

Giving +1 with changes, so it can be merged quickly opnce this is addressed.

@bartaz bartaz merged commit 505b444 into canonical:main Aug 8, 2023
4 checks passed
@bartaz bartaz deleted the dark-forms branch August 8, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants