Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sticky container for docs layout #4895

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Oct 13, 2023

Done

  • add a sticky container to documentation layout to make table of contents sticky and scrollable
  • drive-by: fix overflow in expandable side nav when collapsed

QA

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4895.demos.haus

@bartaz bartaz marked this pull request as ready for review October 13, 2023 14:57
@bartaz bartaz changed the title Sticky docs container Sticky container for docs layout Oct 16, 2023
Copy link
Contributor

@lorumic lorumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bartaz bartaz merged commit 82975b9 into canonical:main Oct 16, 2023
5 checks passed
@bartaz bartaz deleted the sticky-docs-container branch October 16, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants