Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update navigation component a11y documentation #4916

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

aaryanporwal
Copy link
Member

@aaryanporwal aaryanporwal commented Nov 23, 2023

Done

Fixes [list issues/bugs if needed]

QA

  • Open demo
  • [Add QA steps]
  • Review updated documentation:
    • [List any updated documentation for review]

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

[if relevant, include a screenshot or screen capture]

@aaryanporwal aaryanporwal added the Documentation 📝 Documentation changes or updates label Nov 23, 2023
@webteam-app
Copy link

Demo starting at https://vanilla-framework-4916.demos.haus

@bartaz bartaz merged commit 214984e into canonical:main Nov 24, 2023
5 checks passed
@bartaz bartaz changed the title Update navigation component a11y documentation [WD-6207] Update navigation component a11y documentation Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation 📝 Documentation changes or updates Review: Code +1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants