-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dark theme support to notifications #4971
Add dark theme support to notifications #4971
Conversation
Demo starting at https://vanilla-framework-4971.demos.haus |
3a52a96
to
ab0b907
Compare
@chillkang I talked with Lyubo about the status colours and we made a wrong assumption before (about using the tinted borders, as they are designed for different context). So for notification colors we should use whatever notifications used before (semantic colors). Some of them have dark versions: vanilla-framework/scss/_settings_colors.scss Lines 24 to 25 in ab0b907
So instead of exposing them as Also, the "information" icon on dark theme needs to use proper color (whatever icons on dark are using, I think it's white, you can check icons component). |
970936b
to
9054bcd
Compare
…notification icons
9054bcd
to
57296fe
Compare
templates/docs/examples/patterns/notifications/variants-dark.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small tweaks to code needed, but we are getting there! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small fixes needed for themed link color and standalone examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks a lot for that!
Done
light
,paper
, anddark
theme supportFixes
QA
body
class fromis-dark
tois-light
oris-paper
, and check if background of the page and text color change accordinglyScreenshots
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention: