Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename color variables for consistency #4982

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

chillkang
Copy link
Contributor

@chillkang chillkang commented Feb 8, 2024

Done

  • rename css custom properties for status colors

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4982.demos.haus

@chillkang chillkang marked this pull request as ready for review February 8, 2024 10:46
Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@bartaz bartaz changed the title rename css custom properties for status colors Rename color variables for consistency Feb 8, 2024
@bartaz bartaz merged commit 32a10a0 into canonical:main Feb 8, 2024
5 checks passed
@chillkang chillkang deleted the rename-css-color-properties branch February 8, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants