Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Suru to support hero sections with 25/75 and 50/50 main suru backgrounds #4985

Merged
merged 4 commits into from
Feb 9, 2024

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Feb 8, 2024

Done

  • Updates background of default 25/75 suru to latest version of images
  • Adds p-suru--25-75 as an alias to p-suru for consistency with other variants
  • Updates p-suru/p-suru--25-75 to work as a hero section container, providing correct padding and background
  • Updates suru component to use new CSS variables themes for Suru backgrounds
  • Adds p-suru--50-50 variant

Fixes WD-8771
Fixes WD-8772

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image image

- updates the background images to latest versions
- exports backgrounds as CSS variables to be part of the theme
- refactors the suru component to work as a hero section container
@webteam-app
Copy link

Demo starting at https://vanilla-framework-4985.demos.haus

@bartaz bartaz marked this pull request as ready for review February 8, 2024 17:00
@bartaz bartaz added Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Feb 8, 2024
Copy link
Contributor

@britneywwc britneywwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@bartaz bartaz merged commit 322735e into canonical:main Feb 9, 2024
5 checks passed
@bartaz bartaz deleted the hero-suru branch February 9, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants