Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more hero suru variants #4989

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Add more hero suru variants #4989

merged 5 commits into from
Feb 13, 2024

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Feb 9, 2024

Done

Adds more hero suru "corner" backgrounds (fan and pyramid shaped).

Fixes WD-8773

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

(subset of new variants)

image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4989.demos.haus

@bartaz bartaz force-pushed the hero-suru-corner branch 2 times, most recently from 5ff6678 to 48bf318 Compare February 12, 2024 16:06
@bartaz bartaz marked this pull request as ready for review February 12, 2024 16:31
@bartaz bartaz changed the title WIP: Testing hero suru variants Add more hero suru variants Feb 13, 2024
@bartaz bartaz merged commit a58acc2 into canonical:main Feb 13, 2024
5 checks passed
@bartaz bartaz deleted the hero-suru-corner branch February 13, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants