Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strip component to new theming system #4996

Merged
merged 8 commits into from
Feb 16, 2024

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Feb 15, 2024

Done

  • Updates strips to use new theming system with is-light is-dark is-paper class names.
  • Introduces new p-strip--highlighted to replace a variety of strip colour variants with a single themed version of a strip with an alternative backround colour
  • Deprecates a number of old strips that are not meant for new designs: p-strip--dark p-strip--light p-strip--white p-strip--image p-strip--suru, etc. They should be replaced by new themed versions.
  • Updates all the necessary docs and examples.

Fixes WD-8473

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4996.demos.haus

@bartaz bartaz added Review: Design needed Review: QA needed Review: Code needed Feature 🎁 New feature or request Review: Percy needed This PR needs a review of Percy for visual regressions labels Feb 15, 2024
@bartaz bartaz marked this pull request as ready for review February 15, 2024 17:04
@bartaz bartaz added Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Feb 15, 2024
Copy link
Contributor

@britneywwc britneywwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, just need some minor fixes mentioned in the comments

Copy link
Contributor

@britneywwc britneywwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Copy link
Contributor

@lyubomir-popov lyubomir-popov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with a suggestion for the docs.


## White strip
The strip component is rarely used on its own as a container with just `.p-strip` class name. It is usually combined with other variants described below to provide a specific visual style.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The strip component is rarely used on its own as a container with just `.p-strip` class name. It is usually combined with other variants described below to provide a specific visual style.
Strips are containers that apply top/bottom padding and background colour. At a glance:
- Strips come in 3 sizes - shallow, regular and deep. See details below.
- They now support theming.
- You can choose between regular (using the respective theme's background) or highlighted (Using each theme's alternative highlight colour).
The strip component is rarely used on its own as a container with just `.p-strip` class name. It is usually combined with other variants described below to provide a specific visual style.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, reworded a bit to fit better in current docs structure, but I added all of the information you mentioned.

@bartaz bartaz merged commit 0596542 into canonical:main Feb 16, 2024
5 checks passed
@bartaz bartaz deleted the strip-themes branch February 16, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants