-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update strip component to new theming system #4996
Conversation
Demo starting at https://vanilla-framework-4996.demos.haus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, just need some minor fixes mentioned in the comments
… and deprecate many legacy variants
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, with a suggestion for the docs.
|
||
## White strip | ||
The strip component is rarely used on its own as a container with just `.p-strip` class name. It is usually combined with other variants described below to provide a specific visual style. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The strip component is rarely used on its own as a container with just `.p-strip` class name. It is usually combined with other variants described below to provide a specific visual style. | |
Strips are containers that apply top/bottom padding and background colour. At a glance: | |
- Strips come in 3 sizes - shallow, regular and deep. See details below. | |
- They now support theming. | |
- You can choose between regular (using the respective theme's background) or highlighted (Using each theme's alternative highlight colour). | |
The strip component is rarely used on its own as a container with just `.p-strip` class name. It is usually combined with other variants described below to provide a specific visual style. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, reworded a bit to fit better in current docs structure, but I added all of the information you mentioned.
Done
is-light
is-dark
is-paper
class names.p-strip--highlighted
to replace a variety of strip colour variants with a single themed version of a strip with an alternative backround colourp-strip--dark
p-strip--light
p-strip--white
p-strip--image
p-strip--suru
, etc. They should be replaced by new themed versions.Fixes WD-8473
QA
is-light
,is-paper
to check if it adjustsCheck if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots