Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to use new theming #4997

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Update links to use new theming #4997

merged 1 commit into from
Feb 16, 2024

Conversation

bartaz
Copy link
Member

@bartaz bartaz commented Feb 15, 2024

Done

Updated links (and link related components) to use new theming.

Fixes WD-8894

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4997.demos.haus

@bartaz bartaz mentioned this pull request Feb 15, 2024
3 tasks
@bartaz bartaz added Review: QA needed Review: Code needed Feature 🎁 New feature or request Review: Percy needed This PR needs a review of Percy for visual regressions labels Feb 15, 2024
@bartaz bartaz added Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Feb 15, 2024
Copy link
Contributor

@britneywwc britneywwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

@chillkang chillkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bartaz bartaz marked this pull request as ready for review February 16, 2024 08:23
@bartaz bartaz merged commit 91bba88 into canonical:main Feb 16, 2024
5 checks passed
@bartaz bartaz deleted the link-theme branch February 16, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants