Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust columns on mobile view for step-list--detailed #5007

Merged
merged 6 commits into from
Feb 28, 2024
Merged

Conversation

petesfrench
Copy link
Contributor

@petesfrench petesfrench commented Feb 27, 2024

Done

  • Sets columns to 6 at a smaller breakpoint

Fixes #5002

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

Mobile
image

Tablet
image

Desktop
image

@webteam-app
Copy link

Demo starting at https://vanilla-framework-5007.demos.haus

releases.yml Outdated Show resolved Hide resolved
@bartaz
Copy link
Member

bartaz commented Feb 28, 2024

@petesfrench There is some prettier formatting issue in one of the files.

Running dotrun test locally should catch it as well. Or if you have prettier VS Code plugin, it should highlight it as well.

@bartaz bartaz merged commit a9f513d into main Feb 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stepped lists grid is broken in small screens
3 participants