-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nested list counter #5011
Fix nested list counter #5011
Conversation
Demo starting at https://vanilla-framework-5011.demos.haus |
7d04208
to
2cf27d0
Compare
templates/docs/examples/patterns/lists/list-nested-stepped-detailed.html
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM, thanks a lot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some issue with standard stepped list now, that it increases by 2 on each level:
https://vanilla-framework-5011.demos.haus/docs/patterns/lists#vertical-stepped
I haven't checked in detail yet, but maybe counter-increment
happens twice or something like that.
Ohh, Yea. It happens twice for this, I'll look at it |
@codeEmpress1 It seems the issue was that we've been using default browser I moved counter increase to Please review/QA if all looks good from your side. Thanks. |
LGTM! |
Done
[List of work items including drive-bys]
Fixes [list issues/bugs if needed]
#4998
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots
Before
After
[if relevant, include a screenshot or screen capture]