Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested list counter #5011

Merged
merged 7 commits into from
Mar 6, 2024
Merged

Conversation

codeEmpress1
Copy link
Contributor

@codeEmpress1 codeEmpress1 commented Feb 28, 2024

Done

  • Fix nested list counter
    [List of work items including drive-bys]

Fixes [list issues/bugs if needed]
#4998

QA

  • Open demo
  • [Add QA steps]
  • Review updated documentation:
    • [List any updated documentation for review]

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

Before

image

After

Screenshot from 2024-03-01 11-50-32

[if relevant, include a screenshot or screen capture]

@webteam-app
Copy link

Demo starting at https://vanilla-framework-5011.demos.haus

scss/_patterns_lists.scss Outdated Show resolved Hide resolved
@bartaz bartaz changed the title In progress: fix nested list counter WIP: fix nested list counter Feb 29, 2024
@bartaz bartaz marked this pull request as draft February 29, 2024 11:03
@codeEmpress1 codeEmpress1 marked this pull request as ready for review March 1, 2024 09:31
@codeEmpress1 codeEmpress1 changed the title WIP: fix nested list counter Fix nested list counter Mar 1, 2024
Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, thanks a lot!

bartaz
bartaz previously requested changes Mar 1, 2024
Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some issue with standard stepped list now, that it increases by 2 on each level:
https://vanilla-framework-5011.demos.haus/docs/patterns/lists#vertical-stepped

image

I haven't checked in detail yet, but maybe counter-increment happens twice or something like that.

@codeEmpress1
Copy link
Contributor Author

There is some issue with standard stepped list now, that it increases by 2 on each level: https://vanilla-framework-5011.demos.haus/docs/patterns/lists#vertical-stepped

image I haven't checked in detail yet, but maybe `counter-increment` happens twice or something like that.

Ohh, Yea. It happens twice for this, I'll look at it

@bartaz
Copy link
Member

bartaz commented Mar 5, 2024

@codeEmpress1 It seems the issue was that we've been using default browser list-item counter, which is also increased natively by the browser. So the counter was increased both by li element, and by __title class.

I moved counter increase to li element, so this only happens there and not in the title as well. This seems to help.

Please review/QA if all looks good from your side. Thanks.

@codeEmpress1
Copy link
Contributor Author

LGTM!

@bartaz bartaz merged commit 3db17d9 into canonical:main Mar 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants