Fix typography docs #5055
Fix typography docs #5055
Conversation
Demo
Jenkins 
demos.haus 
|
Thanks @dgtlntv, looks good from my point of view. @lyubomir-popov could you have a look if proposed changes are good? |
| @@ -103,9 +107,14 @@ Our type scale consists of 5 font sizes, expressed as rems (root em units). For | |||
| <p class="p-heading--1" style="font-size: 2.5rem; line-height: 3rem">H1 heading</p> | |||
| </td> | |||
| </tr> | |||
| <tr> | |||
| <td>64px</td> | |||
| <td>Ad hoc display headings for important bespoke pages on small and medium screens.</td> | |||
There was a problem hiding this comment.
why the inline styles?
There was a problem hiding this comment.
In order to make sure that the right size is displayed, independent of the screen you are currently on. But I am now realising, that we need to do it both ways actually. So also need to set inline styles for the large screen version.
There was a problem hiding this comment.
I guess the question is what do we want to present here: all the available size options, regardless of screen size - even if we never use them on same screen size (for example, both sizes of h2 heading, both sizes of display heading) - I guess 8 options? - this requires examples with inline styles.
Or do we want to show how many options we have on given screen size (5?): so list 1 row for h2 heading, 1 row for display heading, but maybe mention that their size depends on screen size? (and keep examples responsive)
|
seems ok to me. Can I ask for a drive-by - to fix the column widths of the th's here so these columns in the two tables align: |
I don't know how to properly do that in Vanilla. Is that something you could take care of @bartaz? |
Resizing columns is one of the most annoying things (especially when it requires to replace markdown table with HTML one…) ;) Consider it done :) |
Done
Fixed some of the typography docs to reflect the css more accuratly
QA