Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update team members #5073

Merged
merged 2 commits into from
May 2, 2024
Merged

Update team members #5073

merged 2 commits into from
May 2, 2024

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented May 1, 2024

Done

Closes WD-10921

QA

  • Open demo
  • Verify that @jmuzina, @pastelcyborg have been added to the team members list
  • Verify that elioqoshi is no longer in the team members list
  • Verify that @bartaz job title has been updated to "Staff Web Engineer"

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

@jmuzina jmuzina self-assigned this May 1, 2024
@webteam-app
Copy link

Copy link
Contributor

@jpmartinspt jpmartinspt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmuzina jmuzina merged commit cc34bd3 into canonical:main May 2, 2024
5 checks passed
@jmuzina jmuzina deleted the update-team-members branch May 2, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants