Add text-wrap: pretty to _base_typography.scss

[pastelcyborg]

Done

• Added text-wrap: pretty to _base_typography.scss in order to prevent text widows on browsers that support the pretty value.

• Open demo

• QA: Examine text elements across documentation site and see that no text widows should exist

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

• PR should have one of the following labels to automatically categorise it in release notes:
  • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
• Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
  • if CSS class names are not changed it can be bugfix release (x.x.X)
  • if CSS class names are changed/added/removed it should be minor version (x.X.0)
  • see the wiki for more details
• Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

See below comments for any edge case scenario screenshots.

[webteam-app]

Demo

Jenkins

demos.haus

[bartaz]

Small suggestion on the changelog notes, but otherwise looks good.

[bartaz]

This is the latest build that includes Chrome, so we can see changes it detected.
https://percy.io/bb49709b/vanilla-framework/builds/34249563/changed/1874441928

Most of them are exactly what we expect, although there are few cases where it does a bit unexpected things.

It wraps the date time numbers as if they were words:

https://percy.io/bb49709b/vanilla-framework/builds/34249563/changed/1874441928?browser=chrome&browser_ids=56%2C57&group_snapshots_by=similar_diff&subcategories=unreviewed%2Cchanges_requested&test_case_ids=&viewLayout=overlay&viewMode=new&width=1280&widths=375%2C800%2C1280

Sometimes adjusted wrapping affect not only the last line:

https://percy.io/bb49709b/vanilla-framework/builds/34249563/changed/1874442525?browser=chrome&browser_ids=56%2C57&group_snapshots_by=similar_diff&subcategories=unreviewed%2Cchanges_requested&test_case_ids=&viewLayout=overlay&viewMode=new&width=375&widths=375%2C800%2C1280

But there is likely no way to prevent any of these.

[pastelcyborg]

@bartaz What are your thoughts on those two cases? Do they concern you?

I'm not sure I understand the second example you linked - that appears as expected behavior, to me. Can you explain?

[lyubomir-popov]

I think the date issue is the riskier one. The wrapping is not a major concern (since we've already embarked on simplifying things and sacrificing some control in the process). It should be fairly easy to recover from the date issue, e.g. with a  .