Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds class for anchor links to have visual onhover state #5120

Merged
merged 7 commits into from
Jun 24, 2024
Merged

Conversation

petesfrench
Copy link
Contributor

@petesfrench petesfrench commented Jun 11, 2024

Done

Adds class for anchor links to have visual onhover state

Fixes [list issues/bugs if needed]

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

anchors

@webteam-app
Copy link

@bartaz
Copy link
Member

bartaz commented Jun 17, 2024

As per discussion with Lyubo: we need to update the icon size to always use the default 16px size (even with h2 header).

@bartaz bartaz changed the title feat: Adds class for anchor links to have visual onhover state WIP: Adds class for anchor links to have visual onhover state Jun 17, 2024
@petesfrench
Copy link
Contributor Author

@bartaz updated the icon size. What else do we need to do to get this merged?

@bartaz bartaz changed the title WIP: Adds class for anchor links to have visual onhover state Adds class for anchor links to have visual onhover state Jun 21, 2024
Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go!

@bartaz bartaz merged commit 70b856e into main Jun 24, 2024
12 checks passed
@bartaz bartaz deleted the anchor-tags branch June 24, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants