Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lists pattern to use new color theme variables #5124

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

jmuzina
Copy link
Member

@jmuzina jmuzina commented Jun 11, 2024

Done

Updates the lists pattern to use newer color theme variables.

Affects the following:

  • Color of bullets in unordered lists
  • Color of sequence numbers in ordered lists
  • Color of the bottom border of the last list element in a split list

Fixes WD-11866

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

Before:
Screenshot 2024-06-11 at 2 52 38 PM
After:
Screenshot 2024-06-11 at 2 51 47 PM
Before:
Screenshot 2024-06-11 at 3 10 29 PM
After:
Screenshot 2024-06-11 at 3 11 05 PM

@webteam-app
Copy link

@jmuzina
Copy link
Member Author

jmuzina commented Jun 11, 2024

Note that we don't have great color theme coverage for this component currently, so the dark-theme changes don't really appear in the Percy build.

@jmuzina
Copy link
Member Author

jmuzina commented Jun 11, 2024

@lyubomir-popov Is $colors--theme--border-default the right color to use for bottom border of the last element of a split list or should I use something with more contrast, like $colors--theme--border-low-contrast?

It was previously $color-mid-light.

@jmuzina jmuzina changed the title update lists pattern to use new color theme variables Update lists pattern to use new color theme variables Jun 11, 2024
@jmuzina jmuzina marked this pull request as ready for review June 11, 2024 19:22
scss/_patterns_lists.scss Outdated Show resolved Hide resolved
@bartaz
Copy link
Member

bartaz commented Jun 12, 2024

@lyubomir-popov not sure if we are still using these lists in new designs, but I wonder if we expect the line after the last item?

It's specifically added to "split" version of the list, but it was added such a long time ago it feels like an overlook that we kept it, should we just remove this line and only keep the ones on top of each item?

image

@lyubomir-popov
Copy link
Contributor

no line after anything that is last - lines are always above items

@lyubomir-popov
Copy link
Contributor

applies to tables as well

Copy link
Member

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@bartaz bartaz merged commit f7be758 into canonical:main Jun 14, 2024
6 checks passed
@jmuzina jmuzina deleted the lists-theming branch June 14, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants