-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update lists pattern to use new color theme variables #5124
Conversation
Note that we don't have great color theme coverage for this component currently, so the dark-theme changes don't really appear in the Percy build. |
@lyubomir-popov Is It was previously |
@lyubomir-popov not sure if we are still using these lists in new designs, but I wonder if we expect the line after the last item? It's specifically added to "split" version of the list, but it was added such a long time ago it feels like an overlook that we kept it, should we just remove this line and only keep the ones on top of each item? |
no line after anything that is last - lines are always above items |
applies to tables as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks!
Done
Updates the lists pattern to use newer color theme variables.
Affects the following:
Fixes WD-11866
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots
Before:
After:
Before:
After: