Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Matrix component with new theme color variables #5136

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

pastelcyborg
Copy link
Contributor

@pastelcyborg pastelcyborg commented Jun 13, 2024

Done

  • Updated color variables with low contrast border color variable

Fixes WD-11875

QA

  • Open matrix demo
  • Change theme
  • Witness all colors adapt to appropriate theme

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix release (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

@webteam-app
Copy link

@pastelcyborg pastelcyborg marked this pull request as ready for review June 13, 2024 14:57
@pastelcyborg pastelcyborg added Review: Percy +1 and removed Review: Percy needed This PR needs a review of Percy for visual regressions labels Jun 13, 2024
Copy link
Member

@jmuzina jmuzina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good on code/qa side of things! Just need design review from @lyubomir-popov and we'll be good to go

@pastelcyborg pastelcyborg merged commit f903c92 into canonical:main Jun 14, 2024
6 checks passed
@pastelcyborg pastelcyborg deleted the update-matrix-theming branch June 14, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants